[igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Really confirm error capturing is enabling

Katarzyna Dec katarzyna.dec at intel.com
Thu Jan 24 14:34:24 UTC 2019


On Fri, Jan 18, 2019 at 09:18:01PM +0000, Chris Wilson wrote:
> If the device has error capturing disabled, we still allow previous
> error state to be cleared by a write to sysfs/error. To actually confirm
> that we can capture a fresh error state, we have to perform a read().
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/i915/gem_exec_capture.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
> index f26b4102c..49394c311 100644
> --- a/tests/i915/gem_exec_capture.c
> +++ b/tests/i915/gem_exec_capture.c
> @@ -544,6 +544,7 @@ igt_main
>  
>  		dir = igt_sysfs_open(fd, NULL);
>  		igt_require(igt_sysfs_set(dir, "error", "Begone!"));
> +		igt_require(igt_sysfs_get(dir, "error"));
>  	}
LGTM.
Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>
Kasia :)
>  
>  	for (e = intel_execution_engines; e->name; e++) {
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list