[igt-dev] [PATCH i-g-t 2/3] runner: Warn when watchdogs are being closed from the exit handler

Ser, Simon simon.ser at intel.com
Wed Jul 10 08:20:01 UTC 2019


On Tue, 2019-07-09 at 15:23 +0300, Arkadiusz Hiler wrote:
> instead of being closed normally on a graceful code path
> 
> Cc: Petri Latvala <petri.latvala at intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

Reviewed-by: Simon Ser <simon.ser at intel.com>

> ---
>  runner/executor.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index af02c5a8..6463ab96 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -43,6 +43,9 @@ static void close_watchdogs(struct settings *settings)
>  	if (settings && settings->log_level >= LOG_LEVEL_VERBOSE)
>  		printf("Closing watchdogs\n");
>  
> +	if (settings == NULL && watchdogs.num_dogs != 0)
> +		fprintf(stderr, "Closing watchdogs from exit handler!\n");
> +
>  	for (i = 0; i < watchdogs.num_dogs; i++) {
>  		__close_watchdog(watchdogs.fds[i]);
>  	}


More information about the igt-dev mailing list