[igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources
Ville Syrjälä
ville.syrjala at linux.intel.com
Thu Jul 11 13:49:49 UTC 2019
On Thu, Jul 11, 2019 at 10:41:12AM +0300, Simon Ser wrote:
> The function was called, but the result was never used. Probably a remnant from
> a previous refactoring.
>
> Signed-off-by: Simon Ser <simon.ser at intel.com>
One can probably trust the compiler here.
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> tests/kms_chamelium.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index b749b5598c1d..321fb16b73bd 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -464,14 +464,11 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
> {
> igt_display_t *display = &data->display;
> igt_output_t *output;
> - drmModeRes *res;
> drmModeConnector *connector =
> chamelium_port_get_connector(data->chamelium, port, false);
> enum pipe pipe;
> bool found = false;
>
> - igt_require(res = drmModeGetResources(data->drm_fd));
> -
> /* The chamelium's default EDID has a lot of resolutions, way more then
> * we need to test. Additionally the default EDID doesn't support HDMI
> * audio.
> @@ -501,7 +498,6 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
> igt_output_set_pipe(output, pipe);
>
> drmModeFreeConnector(connector);
> - drmModeFreeResources(res);
>
> return output;
> }
> --
> 2.22.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
More information about the igt-dev
mailing list