[igt-dev] [PATCH i-g-t v4] build: rename Meson options

Arkadiusz Hiler arkadiusz.hiler at intel.com
Tue Jul 16 06:49:38 UTC 2019


On Mon, Jul 15, 2019 at 10:51:17AM +0000, Ser, Simon wrote:
> On Mon, 2019-07-15 at 13:37 +0300, Simon Ser wrote:
> > Meson emits a warning because we use options beginning with "build_":
> > 
> >     DEPRECATION: Option uses prefix "build_", which is reserved for Meson. This will become an error in the future.
> > 
> > Rename our options so that we don't use the Meson-reserved prefix.
> > 
> > Signed-off-by: Simon Ser <simon.ser at intel.com>
> > ---
> > 
> > Changes in v4: added a note in NEWS
> 
> I don't know if non-maintainers adding stuff to NEWS is a good idea.
> 
> For sway/wlroots, we just create an issue about the next release where
> all members can comment to append a breaking change/note for the
> maintainer.

Tracking this as an issue and using some milestone mechanism seems
sensible. Thanks for the suggestion. I am afraid that with bugzilla this
may get easily forgotten, but when issues are migrated to gitlab we'll
give it a shot.

It's ok to add them as points if you are doing some major changes that
definately should not be forgotten. They will get updated, reformatted
and cleaned up for the release anyway.

-- 
Cheers,
Arek


More information about the igt-dev mailing list