[igt-dev] [PATCH i-g-t] lib: Ditch "DRIVER_* for kms tests" cargo cult

Daniel Vetter daniel at ffwll.ch
Tue Jul 16 08:12:34 UTC 2019


On Mon, Jul 15, 2019 at 11:10:19AM +0300, Arkadiusz Hiler wrote:
> On Thu, Jul 11, 2019 at 07:21:35PM +0200, Daniel Vetter wrote:
> > KMS is meant to be a (at least somewhat) generic userspace API. We do
> > not want nor need to add a special match function for every driver
> > ever written, that doesn't make sense, defeats the point of having
> > generic tests for a generic testsuite, and really doesn't scale.
> > 
> > Also add a comment so people don't try to add ever more of these.
> > 
> > Also, this means no autoloading for you, but really igt should
> > reinvent udev, and mostly this was needed for 2 reasons:
> > - CI configuration falling to pieces because tests unloaded a driver,
> >   and then died before cleaning up.
> > - vgem, which is fake, and needs to be requested explictily.
> > 
> > We might want to throw that all out again, except for vgem.
> > 
> > Cc: Liviu Dudau <liviu.dudau at arm.com>
> > Cc: Deepak Rawat <drawat at vmware.com>
> > Cc: Harry Wentland <harry.wentland at amd.com>
> > Cc: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> > Cc: Leo Li <sunpeng.li at amd.com>
> > Cc: MichaƂ Winiarski <michal.winiarski at intel.com>
> > Cc: "Ser, Simon" <simon.ser at intel.com>
> > Cc: Oleg Vasilev <oleg.vasilev at intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> 
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

And pushing, thanks for taking a look.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the igt-dev mailing list