[igt-dev] [PATCH i-g-t] tests: Remove calls to igt_pipe_crc_drain()

Swati Sharma swati2.sharma at intel.com
Thu Jul 25 07:43:51 UTC 2019


Calls to igt_pipe_crc_drain + get_single are already replaced with
igt_pipe_crc_get_current() in patch
https://patchwork.freedesktop.org/patch/240651/?series=47129&rev=1
so removing igt_pipe_crc_drain() shouldn't matter since tests are using
igt_pipe_crc_get_current() which will drain the old junk anyway. Its
double to do drain + get_current(), so calls to drain() can be removed.

Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
 tests/kms_available_modes_crc.c | 3 ---
 tests/kms_cursor_edge_walk.c    | 2 --
 2 files changed, 5 deletions(-)

diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 0777276..786d50e 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -102,7 +102,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
 	igt_plane_set_fb(primary, &data->primary_fb);
 	igt_display_commit2(&data->display, data->commit);
 
-	igt_pipe_crc_drain(data->pipe_crc);
 	igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, &data->cursor_crc);
 	igt_plane_set_fb(primary, NULL);
 	igt_display_commit2(&data->display, data->commit);
@@ -114,7 +113,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
 	igt_plane_set_fb(primary, &data->primary_fb);
 	igt_display_commit2(&data->display, data->commit);
 
-	igt_pipe_crc_drain(data->pipe_crc);
 	igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, &data->fullscreen_crc);
 
 	igt_remove_fb(data->gfx_fd, &data->primary_fb);
@@ -313,7 +311,6 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
 		igt_display_commit2(&data->display, data->commit);
 
 		igt_wait_for_vblank(data->gfx_fd, pipe);
-		igt_pipe_crc_drain(data->pipe_crc);
 		igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, &current_crc);
 
 		if (plane->type != DRM_PLANE_TYPE_CURSOR) {
diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
index 809dca4..87d17e0 100644
--- a/tests/kms_cursor_edge_walk.c
+++ b/tests/kms_cursor_edge_walk.c
@@ -114,8 +114,6 @@ static void test_edge_pos(data_t *data, int sx, int ex, int y, bool swap_axis)
 
 	dx = (ex - sx)/XSTEP;
 
-	igt_pipe_crc_drain(data->pipe_crc);
-
 	i = 0;
 
 	for (x = sx; xdir * (x - ex) <= 0; x += dx) {
-- 
1.9.1



More information about the igt-dev mailing list