[igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk

Stanislav Lisovskiy stanislav.lisovskiy at intel.com
Mon Jul 29 14:15:11 UTC 2019


While doing some gpu fill based tests, noticed that
actually the x and y parameters do not affect the
filled area at all.
After short study looks like gen8_gpgpu_walk was not
using those at all.
Started using those according to bspec, so now it is
actually possible to use initial x and y values.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
---
 lib/gpu_cmds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 8d270ee8..48ddfa0c 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -681,12 +681,12 @@ gen8_emit_gpgpu_walk(struct intel_batchbuffer *batch,
 		  0); /* width:1 */
 
 	/* thread group X */
-	OUT_BATCH(0);
+	OUT_BATCH(x);
 	OUT_BATCH(0);
 	OUT_BATCH(x_dim);
 
 	/* thread group Y */
-	OUT_BATCH(0);
+	OUT_BATCH(y);
 	OUT_BATCH(0);
 	OUT_BATCH(y_dim);
 
-- 
2.17.1



More information about the igt-dev mailing list