[igt-dev] [PATCH i-g-t] runner: Also consider TAINT_MACHINE_CHECK as abortable taint

Daniel Vetter daniel at ffwll.ch
Wed Jun 5 12:36:56 UTC 2019


On Wed, Jun 05, 2019 at 03:16:07PM +0300, Petri Latvala wrote:
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>

I've seen lots of machines where these happen as normal side-effect of
thermal throtlling. For some value of "normal".

Do we really want to reboot on these? It could be like the network thing I
recently disabled, and then everyone started screaming because our
machines where constantly rebooting due to network cards/drivers
temporarily having a bad time (but usually recovering).
-Daniel
> ---
>  runner/executor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 7e5fbe8f..69ef21e5 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -142,6 +142,7 @@ static const struct {
>  	unsigned long bit;
>  	const char *explanation;
>  } abort_taints[] = {
> +  {(1 << 4), "TAINT_MACHINE_CHECK: Processor reported a Machine Check Exception."},
>    {(1 << 5), "TAINT_BAD_PAGE: Bad page reference or an unexpected page flags."},
>    {(1 << 7), "TAINT_DIE: Kernel has died - BUG/OOPS."},
>    {(1 << 9), "TAINT_WARN: WARN_ON has happened."},
> -- 
> 2.19.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the igt-dev mailing list