[igt-dev] [PATCH i-g-t] lib/igt_aux/hang_detector: Don't enable reset if it's explicitly disabled

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 12 13:01:27 UTC 2019


Quoting Arkadiusz Hiler (2019-06-12 13:52:22)
> We don't expect to hang during the tests using hang_detector, and the
> only difference is more severe fallout in case a hang actually happens
> and fewer surprised people seeing reset mysteriously enabled a couple of
> tests down the line.

I don't think this is wise. They can use the existing IGT envars surely?

If the machine is not capable of resets, it shouldn't fall upon the
users to have to disable it.
-Chris


More information about the igt-dev mailing list