[igt-dev] [PATCH i-g-t v6 7/9] igt/i915: Require GTT mapping to be available when needed.

[Chris Wilson]

Quoting Antonio Argenziano (2019-06-14 22:16:55)
> 
> 
> On 14/06/19 02:54, Chris Wilson wrote:
> > Quoting Antonio Argenziano (2019-06-13 22:54:46)
> >> diff --git a/tests/i915/gem_largeobject.c b/tests/i915/gem_largeobject.c
> >> index 518396fa..a2d47edc 100644
> >> --- a/tests/i915/gem_largeobject.c
> >> +++ b/tests/i915/gem_largeobject.c
> >> @@ -84,6 +84,8 @@ igt_simple_main
> >>   
> >>          fd = drm_open_driver(DRIVER_INTEL);
> >>   
> >> +       gem_require_mmap_gtt(fd);
> > 
> > Need to incorporate elsewhere. Or be satisfied with the essentials that
> > we can allocate large objects. Now how large is a matter of debate, I
> > think larger than memory but I haven't yet fixed the kernel.
> 
> Not sure what you mean here. Are you saying we should move the test, or 
> just have a large object allocation test added to something else?

Nah, just questioning the purpose of the test really. It's pretty
useless... If the intent is to take a large object and check that all
ioctls work, it's missing a lot of the driver. On the other hand, we
should have that pretty much covered by the ioctl tests.

I think there is reasonable scope for a "largeobject" test, but
looking at the test it is pretty useless and should just disappear.
-Chris