[igt-dev] [PATCH i-g-t] tests/kms_flip: improve logging when timing out

[Martin Peres]

On 14/06/2019 13:57, Simon Ser wrote:
> Signed-off-by: Simon Ser <simon.ser at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> ---
>  tests/kms_flip.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 2a158d97bbec..3015836c0186 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -686,14 +686,16 @@ static unsigned int run_test_step(struct test_output *o)
>  	    !(o->pending_events & EVENT_VBLANK) && o->flip_state.count > 0) {
>  		struct vblank_reply reply;
>  		unsigned int exp_seq;
> -		unsigned long start;
> +		unsigned long start, end;
> 
>  		exp_seq = o->flip_state.current_seq;
>  		start = gettime_us();
>  		do_or_die(__wait_for_vblank(TEST_VBLANK_ABSOLUTE |
>  					    TEST_VBLANK_BLOCK, o->pipe, exp_seq,
>  					    0, &reply));
> -		igt_assert(gettime_us() - start < 500);
> +		end = gettime_us();
> +		igt_assert_f(end - start < 500, "Wait vblank timed out: %luus",
> +			     end - start);

The message is not super clear. How about:

"Vblank wait took longer than expected: %luus vs %luus\n"

>  		igt_assert_eq(reply.sequence, exp_seq);
>  		igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
>  	}
> --
> 2.22.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>