[igt-dev] [PATCH i-g-t 2/2] tests/kms_chamelium: fix read from uninitialized value in flatline audio test

Simon Ser simon.ser at intel.com
Tue Jun 18 12:55:43 UTC 2019


streak isn't initialized, which makes the test fail in the case in which it's
not zero by chance. This bug has been seen in production™.

Signed-off-by: Simon Ser <simon.ser at intel.com>
---
 tests/kms_chamelium.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 94438e9ae0fc..378024d8fd05 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -1237,6 +1237,7 @@ static bool test_audio_flatline(struct audio_state *state)
 	recv = NULL;
 	recv_len = 0;
 	amp_success = false;
+	streak = 0;
 	while (!amp_success && state->msec < AUDIO_TIMEOUT) {
 		audio_state_receive(state, &recv, &recv_len);
 
-- 
2.22.0



More information about the igt-dev mailing list