[igt-dev] [PATCH i-g-t] i915/gem_pread/pwrite: Rename "basic"

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 27 07:36:15 UTC 2019


The "basic" subtests perform no verification that the read/write work,
only function as mere API exercisers and loose benchmarks. Rename them
to reflect that they are poor benchmarks instead.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 tests/i915/gem_pread.c                | 2 +-
 tests/i915/gem_pwrite.c               | 2 +-
 tests/intel-ci/fast-feedback.testlist | 2 --
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/i915/gem_pread.c b/tests/i915/gem_pread.c
index c64787653..0d3e10b80 100644
--- a/tests/i915/gem_pread.c
+++ b/tests/i915/gem_pread.c
@@ -159,7 +159,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
 		dst_user = malloc(object_size);
 	}
 
-	igt_subtest("basic") {
+	igt_subtest("bench") {
 		for (count = 1; count <= 1<<17; count <<= 1) {
 			struct timeval start, end;
 
diff --git a/tests/i915/gem_pwrite.c b/tests/i915/gem_pwrite.c
index 97703a2aa..37e978791 100644
--- a/tests/i915/gem_pwrite.c
+++ b/tests/i915/gem_pwrite.c
@@ -286,7 +286,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL)
 		src_user = malloc(object_size);
 	}
 
-	igt_subtest("basic") {
+	igt_subtest("bench") {
 		for (count = 1; count <= 1<<17; count <<= 1) {
 			struct timeval start, end;
 
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 8618dfd28..5fcb5e76d 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -87,8 +87,6 @@ igt at gem_mmap_gtt@basic-write-gtt-no-prefault
 igt at gem_mmap_gtt@basic-write-no-prefault
 igt at gem_mmap_gtt@basic-write-read
 igt at gem_mmap_gtt@basic-write-read-distinct
-igt at gem_pread@basic
-igt at gem_pwrite@basic
 igt at gem_render_linear_blits@basic
 igt at gem_render_tiled_blits@basic
 igt at gem_ringfill@basic-default
-- 
2.20.1



More information about the igt-dev mailing list