[igt-dev] [RFC 5/5] tests/kms_plane_scaling: Skip testing unsupported fp16 features

[Strasser, Kevin]

Maarten Lankhorst wrote:
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c 
> > index 1015c80..fed6b3d 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -193,6 +193,14 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
> >  			igt_rotation_t rot = rotations[i];
> >  			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
> >  				unsigned format = plane->drm_plane->formats[j];
> > +
> > +				// Y-tiled 90/270 rotation isn't supported for fp16 on Intel
> > +				if (is_i915_device(d->drm_fd) &&
> > +				    igt_format_is_fp16(format) &&
> > +				    (rot == IGT_ROTATION_90 ||
> > +				     rot == IGT_ROTATION_270))
> > +					continue;
> > +
> >  				if (igt_fb_supported_format(format) &&
> >  				    can_rotate(d, format))
> ^Use this, and perhaps add the rotation as argument?

Makes sense.

> > @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
> >  			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
> >  				uint32_t format = plane->drm_plane->formats[j];
> >  
> > +				// Yf Tiling not supported for fp16 on Intel
> > +				if (is_i915_device(d->drm_fd) &&
> > +				    igt_format_is_fp16(format) &&
> > +				    tiling == LOCAL_I915_FORMAT_MOD_Yf_TILED)
> > +					continue;
> 
> This should be testable with igt_plane_has_format_mod() instead?

Sure, better to take the kernel's lead.

Thanks,
Kevin