[igt-dev] [PATCH v2 2/2] add DROP_SUSPEND.

[Caz Yokoyama]

On Tue, 2019-03-12 at 08:52 -0700, Caz Yokoyama wrote:
> On Tue, 2019-03-12 at 15:30 +0000, Chris Wilson wrote:
> > Quoting Caz Yokoyama (2019-03-12 03:31:32)
> > > +       if (val & DROP_SUSPEND) {
> > > +               struct device *dev = i915->drm.dev;
> > > +
> > > +               dev_info(dev, "%s() %d: runtime_status: %d\n",
> > > __func__, __LINE__,
> > > +                        dev->power.runtime_status);
> > 
> > 
> > > +               pm_runtime_disable(dev);
> > > +               if (!pm_runtime_status_suspended(dev)) {
> > > +                       dev_warn(dev, "%s() %d: runtime_status:
> > > %d\n", __func__, __LINE__,
> > > +                                dev->power.runtime_status);
> > > +               }
> > > +               pm_runtime_enable(dev);
> > 
> > ret = pm_runtime_force_suspend(i915->drm.dev);
> > 
> 
> Yes, this works. However, pm_runtime_force_suspend() always exits on 
> 	if (pm_runtime_status_suspended(dev))
> 		return 0;
Correction. This does not work because of kernel crash. When exiting
from pm_runtime_force_suspend() by pm_runtime_status_suspended(dev) ==
true, pm_runtime_enable(dev) is not called. It looks a bug for me.
-caz

> Therefore, this patch is meaningless after suspended state.
> -caz
> 
> > -Chris
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev