[igt-dev] [PATCH 0/7] some cleanups and uapi clarification for leases
Boris Brezillon
boris.brezillon at collabora.com
Thu Mar 14 08:58:39 UTC 2019
On Thu, 28 Feb 2019 15:49:03 +0100
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Hi all,
>
> Nothing too major, only things I did find in all my igt test extending for
> drm lease is some corner cases around implicit planes and atomic target
> crtcs. Review and comments very much appreciated.
>
> Cheers, Daniel
>
> Test-with: 20190228141918.26043-1-daniel.vetter at ffwll.ch
>
> Daniel Vetter (7):
> drm/leases: Drop object_id validation for negative ids
> drm/lease: Drop recursive leads checks
> drm/leases: Don't init to 0 in drm_master_create
> drm/lease: Check for lessor outside of locks
> drm/lease: Make sure implicit planes are leased
> drm/atomic: Wire file_priv through for property changes
> drm/atomic: -EACCESS for lease-denied crtc lookup
I had a look at patches 5-7 and they seem to do the right thing, but my
knowledge on DRM leases is quite limited, and given all the corner
cases of legacy CRTC/plane updates, I'm not comfortable adding my R-b
on these.
>
> drivers/gpu/drm/drm_atomic_uapi.c | 36 +++++++++++++++++++++++-------------
> drivers/gpu/drm/drm_auth.c | 2 --
> drivers/gpu/drm/drm_crtc.c | 4 ++++
> drivers/gpu/drm/drm_crtc_internal.h | 1 +
> drivers/gpu/drm/drm_lease.c | 13 +++----------
> drivers/gpu/drm/drm_mode_object.c | 5 +++--
> drivers/gpu/drm/drm_plane.c | 8 ++++++++
> 7 files changed, 42 insertions(+), 27 deletions(-)
>
More information about the igt-dev
mailing list