[igt-dev] [PATCH i-g-t] tests/kms_plane: Set output to PIPE_NONE at end of test_format_plane

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Mar 14 12:31:38 UTC 2019


On Wed, Mar 13, 2019 at 04:12:19PM -0400, Nicholas Kazlauskas wrote:
> AMDGPU rejects commits that have an active CRTC without an active
> primary plane.
> 
> The pixel-format-pipe-* tests fail on AMDGPU during the cleanup at
> the end of the test due to the final commit disabling all the planes but
> not the CRTC.
> 
> Disable the CRTC when cleaning up by setting the output to PIPE_NONE.
> 
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  tests/kms_plane.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 9c330ae4..969a61c8 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -586,6 +586,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
>  
>  	igt_plane_set_fb(primary, NULL);
>  	igt_plane_set_fb(plane, NULL);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>  
>  	igt_remove_fb(data->drm_fd, &fb);
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel


More information about the igt-dev mailing list