[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors

[Dhinakaran Pandiyan]

On Thu, 2019-03-14 at 13:03 +0200, Arkadiusz Hiler wrote:
> Currently we are printing one igt_warn for each CRC mismatch, which
> gets
> quite overwhelming with having to see the same error 8 times for each
> color tested:
> 
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> 
> Since the most interesting information here is which format on which
> pipe/plane is broken we can skip igt_warn just once.
> 
> For those weirder and rarer case where just certain colors would fail
> we
> still provide the count:
IMO it's better to have all the information in the logs, particularly
for those 'weirder and rare cases, which are hard to reproduce. And
don't see how count is useful. I think, we should be even logging the
RGB values for the mismatching cases.