[igt-dev] [PATCH v4 1/1] i915_pm_rpm: remove gem-execbuf-stress-extra-wait because same as gem-execbuf-stress
Caz Yokoyama
caz.yokoyama at intel.com
Tue Mar 19 16:44:31 UTC 2019
Extra 5sec delay does not add any value more than gem-execbuf-stress.
It waits until suspend state after a job is added by gem_execbuf().
There is no need to do more when GPU becomes suspended state.
I confirm this by looking at pm_runtime_force_suspend() which exits
on suspend state.
Signed-off-by: Caz Yokoyama <caz.yokoyama at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
tests/i915/i915_pm_rpm.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index be296f52..9a91ca0a 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -1338,12 +1338,13 @@ static void gem_execbuf_stress_subtest(int rounds, int wait_flags)
for (i = 0; i < rounds; i++) {
gem_execbuf(drm_fd, &execbuf);
- if (wait_flags & WAIT_STATUS)
+ if (wait_flags & WAIT_STATUS) {
+ /* clean up idle work */
+ igt_drop_caches_set(drm_fd, DROP_IDLE);
igt_assert(wait_for_suspended());
+ }
if (wait_flags & WAIT_PC8_RES)
igt_assert(pc8_plus_residency_changed(30));
- if (wait_flags & WAIT_EXTRA)
- sleep(5);
}
gem_close(drm_fd, handle);
@@ -2083,8 +2084,6 @@ int main(int argc, char *argv[])
gem_execbuf_stress_subtest(rounds, WAIT_STATUS);
igt_subtest("gem-execbuf-stress-pc8")
gem_execbuf_stress_subtest(rounds, WAIT_PC8_RES);
- igt_subtest("gem-execbuf-stress-extra-wait")
- gem_execbuf_stress_subtest(rounds, WAIT_STATUS | WAIT_EXTRA);
/* power-wake reference tests */
igt_subtest("pm-tiling")
--
2.17.1
More information about the igt-dev
mailing list