[igt-dev] [PATCH v13 7/9] lib/igt_gt: use for_each_engine_class_instance to loop through active engines

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Mar 20 10:33:43 UTC 2019


On 20/03/2019 10:09, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-03-20 10:04:50)
>>
>> On 19/03/2019 23:44, Andi Shyti wrote:
>> If you do this, and also add vcs2 to the static table in this series,
> 
> Can we give the static table every class with up to MAX_INSTANCE^2?
> Shotgun approach.

Problem is test enumeration is driven of it and we are not allowed to 
access the device in that phase. And I don't think we want to enumerate 
a gazillion of subtests just to make the static table future proof.

So I was thinking Andi would be adding an assert in the code which 
borrows the name from the static table so we notice it needs to be 
expanded for new engines.

Regards,

Tvrtko


More information about the igt-dev mailing list