[igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings

[Kumar Valsan, Prathap]

On Tue, Mar 19, 2019 at 07:23:20PM +0000, Chris Wilson wrote:
> Don't try to evaluate whether reads executed on an absent ring do
> anything.

Chris,

I am trying to understand this patch and has this question.
AFAIK every GPU engine has an assosiated ring buffer per
context. Absent ring is a error case?

Thanks,
Prathap
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/i915/gem_mocs_settings.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 21f7c6e12..1a311b8c0 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -564,8 +564,8 @@ igt_main
>  			}
>  		}
>  
> -		igt_subtest_f("mocs-isolation-%s",
> -			      e->name) {
> +		igt_subtest_f("mocs-isolation-%s", e->name) {
> +			gem_require_ring(fd, e->exec_id | e->flags);
>  			gem_require_contexts(fd);
>  
>  			isolation_test(fd, e->exec_id | e->flags);
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev