[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Ensure minimum height and width for planar uyv formats

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Thu Mar 21 09:02:25 UTC 2019


Looks good,

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 20.3.2019 11.22, Mika Kahola wrote:
> Let's ensure that we test with minimum width and height of 16 for all planar uyv formats.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=110098
> Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> ---
>   tests/kms_plane_scaling.c | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index d408a203..01f5f7c9 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -60,6 +60,19 @@ static int get_num_scalers(data_t* d, enum pipe pipe)
>   		return 1;
>   }
>   
> +static bool is_planar_yuv_format(uint32_t pixelformat)
> +{
> +	switch (pixelformat) {
> +	case DRM_FORMAT_NV12:
> +	case DRM_FORMAT_P010:
> +	case DRM_FORMAT_P012:
> +	case DRM_FORMAT_P016:
> +		return true;
> +	default:
> +		return false;
> +	}
> +}
> +
>   static void cleanup_fbs(data_t *data)
>   {
>   	int i;
> @@ -136,7 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>   
>   	/* create buffer in the range of  min and max source side limit.*/
>   	width = height = 8;
> -	if (pixel_format == DRM_FORMAT_NV12)
> +	if (is_planar_yuv_format(pixel_format))
>   		width = height = 16;
>   	igt_create_color_fb(display->drm_fd, width, height,
>   		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> 



More information about the igt-dev mailing list