[igt-dev] [PATCH i-g-t] lib: Make igt_device_get_pci_addr non-static.

[Chris Wilson]

Quoting Katarzyna Dec (2019-03-21 09:53:39)
> Let's make igt_pci_addr struct and igt_device_get_pci_addr
> non-static to be able to use them in tests.

Can do. Please send interface changes with the consumer so we can see
the bigger picture.
 
> Signed-off-by: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  lib/igt_device.c | 9 +--------
>  lib/igt_device.h | 8 ++++++++
>  2 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/igt_device.c b/lib/igt_device.c
> index a2f9bb3a..fec84609 100644
> --- a/lib/igt_device.c
> +++ b/lib/igt_device.c
> @@ -130,14 +130,7 @@ static bool igt_device_is_pci(int fd)
>         return strcmp(subsystem, "/pci") == 0;
>  }
>  
> -struct igt_pci_addr {
> -       unsigned int domain;
> -       unsigned int bus;
> -       unsigned int device;
> -       unsigned int function;
> -};

If we are going to export it, should we make this 4x uint16_t?
-Chris