[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Minimum width and height for planar YUV formats on i915 devices

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Mar 21 18:26:25 UTC 2019


On Thu, Mar 21, 2019 at 03:57:14PM +0200, Mika Kahola wrote:
> Use minimum of 16x16 size for i915 devices only as other HW's may have different limitations.
> The default is 8x8.

I guess the 8x8 is equally arbitrary for other devices. But maybe it's
a good enough default?

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> 
> Suggested-by: Ville Syrjala <ville.syrjala at linux.intel.com>
> Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> ---
>  tests/kms_plane_scaling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 01f5f7c9..10c852d5 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -149,7 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 8;
> -	if (is_planar_yuv_format(pixel_format))
> +	if (is_i915_device(d->drm_fd) && is_planar_yuv_format(pixel_format))
>  		width = height = 16;
>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> -- 
> 2.17.1

-- 
Ville Syrjälä
Intel


More information about the igt-dev mailing list