[igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test

Uma Shankar uma.shankar at intel.com
Fri Mar 22 14:17:33 UTC 2019


Due to Gamma/Degamma limitation with precision (lack of
exact 1.0 representation) due to ABI restriction, applying
linear gamma affects crc. This patch fixes the same by making
ctm tests independant of gamma/degamma.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Signed-off-by: Uma Shankar <uma.shankar at intel.com>
---
 tests/kms_color.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..0656682 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -662,13 +662,9 @@ static bool test_pipe_ctm(data_t *data,
 		0.0, 1.0, 0.0,
 		0.0, 0.0, 1.0
 	};
-	double *degamma_linear, *gamma_linear;
 	igt_output_t *output;
 	bool ret = true;
 
-	degamma_linear = generate_table(data->degamma_lut_size, 1.0);
-	gamma_linear = generate_table(data->gamma_lut_size, 1.0);
-
 	for_each_valid_output_on_pipe(&data->display, primary->pipe->pipe, output) {
 		drmModeModeInfo *mode;
 		struct igt_fb fb_modeset, fb;
@@ -696,8 +692,6 @@ static bool test_pipe_ctm(data_t *data,
 		igt_assert(fb_modeset_id);
 		igt_plane_set_fb(primary, &fb_modeset);
 
-		set_degamma(data, primary->pipe, degamma_linear);
-		set_gamma(data, primary->pipe, gamma_linear);
 		disable_ctm(primary->pipe);
 		igt_display_commit(&data->display);
 
@@ -725,9 +719,6 @@ static bool test_pipe_ctm(data_t *data,
 		igt_output_set_pipe(output, PIPE_NONE);
 	}
 
-	free(degamma_linear);
-	free(gamma_linear);
-
 	return ret;
 }
 
-- 
1.9.1



More information about the igt-dev mailing list