[igt-dev] [PATCH i-g-t] Revert "lib/igt_device: Move intel_get_pci_device under igt_device"

[Michał Winiarski]

On Wed, Mar 27, 2019 at 09:03:37PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> One significant usecase for intel_reg/etc. is to be able to examine
> the hardware state *before* loading the driver. If the tool forces
> the driver to load we've totally lost that capability.
> 
> This reverts commit 8ae86621d6fff60b6e20c6b0f9b336785c935b0f.
> 
> Cc: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

I still think it was a small step in the right direction, but if it breaks your
usecase:

Acked-by: Michał Winiarski <michal.winiarski at intel.com>

(I'm not giving up on killing intel_get_pci_device from the tests, so expect a
revert-revert ;) )

-Michał

> ---
>  benchmarks/gem_latency.c        |   4 +-
>  benchmarks/gem_wsim.c           |   4 +-
>  debugger/debug_rdata.c          |   7 +-
>  debugger/eudb.c                 |   8 +--
>  lib/igt_device.c                | 120 --------------------------------
>  lib/igt_device.h                |   1 -
>  lib/intel_chipset.c             |  51 ++++++++++++++
>  lib/intel_chipset.h             |   1 +
>  lib/intel_mmio.c                |   4 +-
>  lib/ioctl_wrappers.c            |   5 +-
>  lib/ioctl_wrappers.h            |   2 +-
>  tests/i915/gem_concurrent_all.c |  12 ++--
>  tests/i915/gem_cpu_reloc.c      |   4 +-
>  tests/i915/gem_exec_latency.c   |   3 +-
>  tests/i915/gem_exec_parse.c     |   4 +-
>  tests/i915/gem_mmap.c           |   4 +-
>  tests/i915/gem_mmap_gtt.c       |  10 +--
>  tests/i915/gem_pwrite.c         |   4 +-
>  tests/i915/gem_shrink.c         |   2 +-
>  tests/i915/i915_pm_lpsp.c       |   3 +-
>  tests/i915/i915_pm_rpm.c        |   4 +-
>  tests/kms_flip.c                |   2 +-
>  tests/prime_mmap.c              |   4 +-
>  tools/intel_audio_dump.c        |   9 +--
>  tools/intel_backlight.c         |   8 +--
>  tools/intel_display_poller.c    |   8 +--
>  tools/intel_forcewaked.c        |  10 +--
>  tools/intel_gpu_time.c          |   8 +--
>  tools/intel_gtt.c               |   8 +--
>  tools/intel_infoframes.c        |   7 +-
>  tools/intel_l3_parity.c         |   3 +-
>  tools/intel_lid.c               |   9 +--
>  tools/intel_panel_fitter.c      |   8 +--
>  tools/intel_perf_counters.c     |   3 +-
>  tools/intel_reg.c               |  23 +++---
>  tools/intel_reg_checker.c       |   8 +--
>  tools/intel_watermark.c         |  23 +++---
>  37 files changed, 131 insertions(+), 267 deletions(-)