[igt-dev] [PATCH i-g-t] i915/gem_exec_big: Only warn for the first sign of a pagefault
Chris Wilson
chris at chris-wilson.co.uk
Thu Mar 28 11:49:25 UTC 2019
We only need the warning once, not for the several thousand relocations
we try. The current execbuf implementation will set all presumed_offset
to -1 so this loop should quit on the first entry if we hit the
pagefault, but for the sake of completeness check all.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110269
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index 440136ee8..9da90ead6 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -169,8 +169,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
igt_permute_array(gem_reloc, nreloc, xchg_reloc);
gem_execbuf(fd, &execbuf);
- for (n = 0; n < nreloc; n++)
- igt_warn_on(gem_reloc[n].presumed_offset == -1);
+ for (n = 0; n < nreloc; n++) {
+ if (igt_warn_on(gem_reloc[n].presumed_offset == -1))
+ break;
+ }
if (use_64bit_relocs) {
for (n = 0; n < nreloc; n++) {
--
2.20.1
More information about the igt-dev
mailing list