[igt-dev] [v4] tests/kms_color: Fix CRC mismatch issues with ctm test

Uma Shankar uma.shankar at intel.com
Thu Mar 28 21:59:55 UTC 2019


Due to Gamma/Degamma limitation with precision (lack of
exact 1.0 representation) due to ABI restriction, applying
linear gamma affects crc. This patch fixes the same by making
ctm tests independant of gamma/degamma.

v2: Disable degamma/gamma programming for ctm max test as it
leads to crc mimsmatch. Limiting it to this test case alone as
other tests need it to be enabled, hence not touching those
scenarios.

v3: Fixed a fumble with compilation.

v4: Disabling degamma and gamma for ctm max tests, after the logic
in kernel has been updated by Ville's series.

v5: Disabled gamma/degamma for all ctm tests as suggested by Ville.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Signed-off-by: Uma Shankar <uma.shankar at intel.com>
---
 tests/kms_color.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..2a6f4b7 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -696,9 +696,10 @@ static bool test_pipe_ctm(data_t *data,
 		igt_assert(fb_modeset_id);
 		igt_plane_set_fb(primary, &fb_modeset);
 
-		set_degamma(data, primary->pipe, degamma_linear);
-		set_gamma(data, primary->pipe, gamma_linear);
+		disable_degamma(primary->pipe);
+		disable_gamma(primary->pipe);
 		disable_ctm(primary->pipe);
+
 		igt_display_commit(&data->display);
 
 		paint_rectangles(data, mode, after, &fb);
-- 
1.9.1



More information about the igt-dev mailing list