[igt-dev] [PATCH v16 1/8] lib/igt_gt: remove unnecessary argument

[Tvrtko Ursulin]

On 28/03/2019 19:21, Andi Shyti wrote:
> __for_each_engine_class_instance(fd, e) doesn't need and doesn't
> use the fd argument. Remove it.
> 
> Signed-off-by: Andi Shyti <andi.shyti at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> ---
>   lib/igt_gt.h     | 2 +-
>   tests/perf_pmu.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_gt.h b/lib/igt_gt.h
> index 54e95da98084..475c0b3c3cc6 100644
> --- a/lib/igt_gt.h
> +++ b/lib/igt_gt.h
> @@ -114,7 +114,7 @@ void gem_require_engine(int gem_fd,
>   	igt_require(gem_has_engine(gem_fd, class, instance));
>   }
>   
> -#define __for_each_engine_class_instance(fd__, e__) \
> +#define __for_each_engine_class_instance(e__) \
>   	for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
>   
>   #define for_each_engine_class_instance(fd__, e__) \
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 1a08f564b066..4f552bc2ae28 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -1693,7 +1693,7 @@ igt_main
>   	igt_subtest("invalid-init")
>   		invalid_init();
>   
> -	__for_each_engine_class_instance(fd, e) {
> +	__for_each_engine_class_instance(e) {
>   		const unsigned int pct[] = { 2, 50, 98 };
>   
>   		/**
> @@ -1897,7 +1897,7 @@ igt_main
>   			gem_quiescent_gpu(fd);
>   		}
>   
> -		__for_each_engine_class_instance(render_fd, e) {
> +		__for_each_engine_class_instance(e) {
>   			igt_subtest_group {
>   				igt_fixture {
>   					gem_require_engine(render_fd,
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko