[igt-dev] [PATCH v16 5/8] tests: gem_exec_basic: add engine discovery test

[Tvrtko Ursulin]

On 29/03/2019 12:06, Andi Shyti wrote:
>>> +	igt_subtest("exec-physical-engines-ctx") {
>>> +		uint64_t ctx_id;
>>> +		struct intel_execution_engine2 *e2;
>>> +
>>> +		ctx_id = gem_context_create(fd);
>>
>> In this one you don't want a context. It creates a mismatch between execbuf
>> sent by gem_context_has_engine and a context which hasn't been configured to
>> use engine index addressing.
> 
> Yes, I forgot to remove it... BTW, is this test needed at all? I
> added it just as a proposal.

In my opinion you can drop this patch since you use both new iterators 
later in the series.

Regards,

Tvrtko