[igt-dev] [PATCH v23 08/14] test/i915: gem_cs_tlb: use the gem_engine_topology library

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon May 13 10:43:41 UTC 2019


On 13/05/2019 01:45, Andi Shyti wrote:
> From: Andi Shyti <andi.shyti at intel.com>
> 
> Replace the legacy for_each_engine* defines with the ones
> implemented in the gem_engine_topology library.
> 
> Signed-off-by: Andi Shyti <andi.shyti at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
>   tests/i915/gem_cs_tlb.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/i915/gem_cs_tlb.c b/tests/i915/gem_cs_tlb.c
> index 51e1c4e19930..13de5499f1c7 100644
> --- a/tests/i915/gem_cs_tlb.c
> +++ b/tests/i915/gem_cs_tlb.c
> @@ -140,7 +140,7 @@ static void run_on_ring(int fd, unsigned ring_id, const char *ring_name)
>   
>   igt_main
>   {
> -	const struct intel_execution_engine *e;
> +	const struct intel_execution_engine2 *e;
>   	int fd = -1;
>   
>   	igt_skip_on_simulation();
> @@ -150,9 +150,9 @@ igt_main
>   		igt_require_gem(fd);
>   	}
>   
> -	for (e = intel_execution_engines; e->name; e++)
> -		igt_subtest_f("%s%s", e->exec_id ? "" : "basic-", e->name)
> -			run_on_ring(fd, e->exec_id | e->flags, e->name);
> +	__for_each_physical_engine(fd, e)
> +		igt_subtest_f("%s", e->name)
> +			run_on_ring(fd, e->flags, e->name);
>   
>   	igt_fixture
>   		close(fd);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the igt-dev mailing list