[igt-dev] [PATCH v23 07/14] test/i915: gem_busy: use the gem_engine_topology library

Chris Wilson chris at chris-wilson.co.uk
Mon May 13 10:58:24 UTC 2019


Quoting Tvrtko Ursulin (2019-05-13 11:42:49)
> 
> On 13/05/2019 01:45, Andi Shyti wrote:
> > -static void basic(int fd, unsigned ring, unsigned flags)
> > +static void basic(int fd, const struct intel_execution_engine2 *e, bool hang)
> 
> I would have left the flags for a smaller diff but okay.

Rather prefer flags over multiple bool args, and certainly do not
randomly replace flags with bools. flags are much easier to read than
multiple booleans.
-Chris


More information about the igt-dev mailing list