[igt-dev] [PATCH v24 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class

Chris Wilson chris at chris-wilson.co.uk
Tue May 14 09:07:57 UTC 2019


Quoting Andi Shyti (2019-05-13 18:56:03)
> -bool gem_can_store_dword(int fd, unsigned int engine)
> +bool gem_class_can_store_dword(int fd, int class)
>  {
>         uint16_t devid = intel_get_drm_devid(fd);
>         const struct intel_device_info *info = intel_get_device_info(devid);
> @@ -569,8 +569,8 @@ bool gem_can_store_dword(int fd, unsigned int engine)
>         if (gen == 3 && (info->is_grantsdale || info->is_alviso))
>                 return false; /* only supports physical addresses */
>  
> -       if (gen == 6 && ((engine & 0x3f) == I915_EXEC_BSD))
> -               return false; /* kills the machine! */
> +       if (gen == 6 && class == I915_ENGINE_CLASS_VIDEO)
> +               return false;

Probably wise to keep the note about why it is excluded. It's a nasty
surprise.
-Chris


More information about the igt-dev mailing list