[igt-dev] [Intel-gfx] [PATCH i-g-t] benchmarks/gem_wsim: Randomise random seed

[Chris Wilson]

Quoting Tvrtko Ursulin (2019-05-17 09:28:46)
> 
> On 16/05/2019 19:58, Chris Wilson wrote:
> > To avoid hitting the same rut on each benchmark run, start with a new
> > random seed. To allow hitting the same rut again, let it be specified
> > by the user.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > ---
> >   benchmarks/gem_wsim.c | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> > index 48568ce40..cf2a44746 100644
> > --- a/benchmarks/gem_wsim.c
> > +++ b/benchmarks/gem_wsim.c
> > @@ -2282,8 +2282,9 @@ int main(int argc, char **argv)
> >       igt_require(fd);
> >   
> >       init_clocks();
> > +     srand(time(NULL));
> >   
> > -     while ((c = getopt(argc, argv, "hqv2RSHxGdc:n:r:w:W:a:t:b:p:")) != -1) {
> > +     while ((c = getopt(argc, argv, "hqv2RSHxGdc:n:r:w:W:a:t:b:p:s:")) != -1) {
> >               switch (c) {
> >               case 'W':
> >                       if (master_workload >= 0) {
> > @@ -2300,6 +2301,9 @@ int main(int argc, char **argv)
> >               case 'p':
> >                       prio = atoi(optarg);
> >                       break;
> > +             case 's':
> > +                     srand(atoi(optarg));
> > +                     break;
> >               case 'a':
> >                       if (append_workload_arg) {
> >                               if (verbose)
> > 
> 
> Makes sense, just the help text missing.

You use 's' for sseu, I think I (Initial random seed) is one of the few
available.

> I was initially confused at srand when I thought I used your 
> hars_petruska library routines but then saw rand() feeds the seed into 
> those.

Yeah, I had to go and double check that we actually used rand()
somewhere (and not just in my hacks :)
-Chris