[igt-dev] [PATCH] tests/kms_rotation_crc: enable bad-pixel-format subtest for gen11+

[Juha-Pekka Heikkila]

Look ok to me.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 20.5.2019 12.48, Swati Sharma wrote:
> Currently, subtest bad-pixel-format is getting skipped for gen11.
> To enable this for gen11+ platforms, added override_fmt - which could
> be any gen11+ format not allowing 90/270 degree rotation like C8,
> Y210, Y212, Y216, etc.
> 
> DRM_FORMAT_C8 fmt needs to be enabled for IGT, so this can't be used
> yet. So, I have used DRM_FORMAT_Y212 which is enabled in IGT.
> 
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
>   tests/kms_rotation_crc.c | 13 ++++++-------
>   1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index fc995d0..fe40481 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -805,14 +805,13 @@ igt_main
>   	data.pos_y = 0;
>   
>   	igt_subtest_f("bad-pixel-format") {
> -		/*
> -		 * gen11 enables RGB565 rotation for 90/270 degrees.
> -		 * DRM_FORMAT_C8 fmt need to be enabled for IGT if want to run
> -		 * this test on gen11 and later.
> -		 */
> -		igt_require(gen >= 9 && gen < 11);
> +		 /* gen11 enables RGB565 rotation for 90/270 degrees.
> +		  * so apart from this, any other gen11+ pixel format
> +		  * can be used which doesn't support 90/270 degree
> +		  * rotation */
> +		igt_require(gen >= 9);
>   		data.rotation = IGT_ROTATION_90;
> -		data.override_fmt = DRM_FORMAT_RGB565;
> +		data.override_fmt = gen < 11 ? DRM_FORMAT_RGB565 : DRM_FORMAT_Y212;
>   		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
>   	}
>   	data.override_fmt = 0;
>