[igt-dev] [PATCH] test/i915: gem_busy: fix misuse of the "flags" parameter in basic()

Andi Shyti andi.shyti at intel.com
Wed May 22 22:13:02 UTC 2019


The "flags" parameter received by the "basic()" function checks
for the HANG (0x2) bit, while callers give it a boolean
true/false value.

Restore the original meaning of "flags" as a bit mask.

Fixes: 88318b0771f9 ("test/i915: gem_busy: use the gem_engine_topology library")
Signed-off-by: Andi Shyti <andi.shyti at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
 tests/i915/gem_busy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 2872e7b7be62..781a3bfab1d1 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -483,7 +483,7 @@ igt_main
 					      e->class == I915_ENGINE_CLASS_RENDER
 					      ? "basic-" : "", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e, false);
+					basic(fd, e, 0);
 				}
 			}
 		}
@@ -548,7 +548,7 @@ igt_main
 				      ? "basic-" : "", e->name) {
 				igt_skip_on_simulation();
 				gem_quiescent_gpu(fd);
-				basic(fd, e, true);
+				basic(fd, e, HANG);
 			}
 		}
 
-- 
2.20.1



More information about the igt-dev mailing list