[igt-dev] [PATCH i-g-t 1/2] tests/kms_big_fb: Run the test for a single pipe only

Ville Syrjala ville.syrjala at linux.intel.com
Thu May 23 20:19:34 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

I think we can safely assume that if no plane on the first
available pipe supports the format+mod+rotation combo we
don't have to check on all the other pipes.

The only slight exception is CHV where pipe B has a few more
features, but none of those are actually relevant for this
test.

Also leave put the PIPE_ANY commit as that still causes
pointless modesets.

$ time kms_big_fb
- real    2m8.101s
+ real    0m52.902s

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/kms_big_fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index 2f898074ad54..c3520e225ab9 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -344,8 +344,6 @@ static bool test_pipe(data_t *data)
 	igt_pipe_crc_free(data->pipe_crc);
 
 	igt_output_set_pipe(data->output, PIPE_ANY);
-	igt_display_commit2(&data->display, data->display.is_atomic ?
-			    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
 
 	igt_remove_fb(data->drm_fd, &data->small_fb);
 
@@ -357,6 +355,7 @@ static void test_scanout(data_t *data)
 	for_each_pipe_with_valid_output(&data->display, data->pipe, data->output) {
 		if (test_pipe(data))
 			return;
+		break;
 	}
 
 	igt_skip("unsupported configuration\n");
-- 
2.21.0



More information about the igt-dev mailing list