[igt-dev] [PATCH i-g-t 2/3] meson: Mark pciaccess and kmod as required

Ser, Simon simon.ser at intel.com
Wed May 29 10:54:54 UTC 2019


On Wed, 2019-05-29 at 13:51 +0300, Petri Latvala wrote:
> libpciaccess and libkmod have been mandatory already, but not marked
> as required.

I thought mandatory deps were the default?

In other words, I believe this:

   libkmod = dependency('libkmod')

Makes libkmod a mandatory dep.

> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Cc: Simon Ser <simon.ser at intel.com>
> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 6268c58d..336ce4e6 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -114,8 +114,8 @@ endif
>  
>  build_info += 'With libdrm: ' + ','.join(libdrm_info)
>  
> -pciaccess = dependency('pciaccess', version : '>=0.10')
> -libkmod = dependency('libkmod')
> +pciaccess = dependency('pciaccess', version : '>=0.10', required : true)
> +libkmod = dependency('libkmod', required : true)
>  libprocps = dependency('libprocps', required : true)
>  
>  libunwind = dependency('libunwind', required : get_option('with_libunwind'))


More information about the igt-dev mailing list