[igt-dev] [PATCH V3 i-g-t] lib: Drop __kms_addfb() wrapper

[Rodrigo Siqueira]

Hi Chris,

Thank you for your feedback and the explanation about igt_ioctl, now
I've got it.

On Mon, May 27, 2019 at 7:13 AM Chris Wilson <chris at chris-wilson.co.uk> wrote:
>
> Quoting Rodrigo Siqueira (2019-05-27 02:19:51)
> > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a
> > similar code. Due to this similarity, this commit replaces all the
> > occurrences of  __kms_addfb() by drmModeAddFB2WithModifiers() and adds
> > the required adaptations.
>
> No. There is a critical difference between the two: igt_ioctl. That
> allows us to control the ioctl for error injection into the kernel.
>
> If you want to test libdrm API and not the kernel, please add tests
> to libdrm.
> -Chris



-- 

Rodrigo Siqueira
https://siqueira.tech