[igt-dev] [PATCH i-g-t 2/2] tests/kms_dp_dsc: Add a subtest to force DSC output BPP

Anusha anusha.srivatsa at intel.com
Wed May 29 23:39:38 UTC 2019


From: Anusha Srivatsa <anusha.srivatsa at intel.com>

This subtest uses the accepted DSC BPPs and tries to
force a modeset by setting a certain BPP as the output
BPP for a connector.

Cc: Petri Latvala <petri.latvala at intel.com>
Cc: Manasi Navare <manasi.d.navare at intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
---
 tests/kms_dp_dsc.c | 60 ++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 56 insertions(+), 4 deletions(-)

diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c
index b99037af..5dde1e79 100644
--- a/tests/kms_dp_dsc.c
+++ b/tests/kms_dp_dsc.c
@@ -46,7 +46,8 @@
 
 enum dsc_test_type
 {
-	test_basic_dsc_enable
+	test_basic_dsc_enable,
+	test_basic_dsc_enable_bpp
 };
 
 typedef struct {
@@ -67,6 +68,7 @@ typedef struct {
 
 bool force_dsc_en_orig;
 int force_dsc_restore_fd = -1;
+int new_bpp;
 
 static inline void manual(const char *expected)
 {
@@ -159,6 +161,18 @@ static void restore_force_dsc_en(void)
 	force_dsc_restore_fd = -1;
 }
 
+static void force_dp_dsc_enable_bpp(data_t *data)
+{
+	char file_name[128] = {0};
+	int ret;
+	char buffer[20];
+	sprintf(buffer, "%d", new_bpp);
+	strcpy(file_name, data->conn_name);
+	strcat(file_name, "/i915_dsc_bpp_slice_support");
+	igt_debug ("Forcing DSC BPP to %d on %s\n", new_bpp, data->conn_name);
+	ret = igt_sysfs_write(data->debugfs_fd, file_name, buffer, sizeof(buffer));
+}
+
 static void test_cleanup(data_t *data)
 {
 	igt_plane_t *primary;
@@ -231,9 +245,38 @@ static void update_display(data_t *data, enum dsc_test_type test_type)
 			     "Default DSC enable failed on Connector: %s Pipe: %s\n",
 			     data->conn_name,
 			     kmstest_pipe_name(data->pipe));
-	} else {
+	} else if (test_type == test_basic_dsc_enable_bpp) {
+
+	igt_debug("DSC is supported on %s\n", data->conn_name);
+
+	save_force_dsc_en(data);
+	force_dp_dsc_enable(data);
+
+	igt_debug("Trying to set BPP to %d\n", new_bpp);
+
+	force_dp_dsc_enable_bpp(data);
+
+	igt_output_set_pipe(data->output, data->pipe);
+	igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay,
+			      data->mode->vdisplay,
+			      DRM_FORMAT_XRGB8888,
+			      LOCAL_DRM_FORMAT_MOD_NONE,
+			      &data->fb_test_pattern);
+	primary = igt_output_get_plane_type(data->output,
+					    DRM_PLANE_TYPE_PRIMARY);
+
+	/* Now set the output to the desired mode */
+	igt_plane_set_fb(primary, &data->fb_test_pattern);
+	igt_display_commit(&data->display);
+
+	/*
+	 * Until we have CRC check support, manually check if RGB test
+	 * pattern has no corruption.
+	 */
+	manual("RGB test pattern without corruption");
+
+	} else
 		igt_assert(!"Unknown test type\n");
-	}
 }
 
 static void run_test(data_t *data, igt_output_t *output,
@@ -258,7 +301,8 @@ igt_main
 	igt_output_t *output;
 	drmModeRes *res;
 	drmModeConnector *connector;
-	int i, test_conn_cnt, test_cnt;
+	int i, j, test_conn_cnt, test_cnt;
+	int dp_dsc_supported_compressed_bpp[] = {8, 10, 12, 15};
 	int tests[] = {DRM_MODE_CONNECTOR_eDP, DRM_MODE_CONNECTOR_DisplayPort};
 
 	igt_fixture {
@@ -298,6 +342,14 @@ igt_main
 			igt_subtest_f("basic-dsc-enable-%s",
 				      kmstest_connector_type_str(tests[test_cnt]))
 			run_test(&data, output, test_basic_dsc_enable);
+
+			/* Loop through all accepted DSC BPP's */
+			for (j = 0; j < ARRAY_SIZE(dp_dsc_supported_compressed_bpp); j++) {
+				new_bpp = dp_dsc_supported_compressed_bpp[j];
+				igt_subtest_f("basic-dsc-enable-%dbpp-%s", new_bpp,
+					      kmstest_connector_type_str(tests[test_cnt]))
+				run_test(&data, output, test_basic_dsc_enable_bpp);
+			}
 			igt_skip_on(test_conn_cnt == 0);
 		}
 	}
-- 
2.17.1



More information about the igt-dev mailing list