[igt-dev] [PATCH i-g-t] intel-ci: Relegate gem_exec_reloc to the shards

Tomi Sarvela tomi.p.sarvela at intel.com
Fri Nov 1 12:58:16 UTC 2019


On 11/1/19 1:21 PM, Petri Latvala wrote:
> On Fri, Nov 01, 2019 at 10:56:37AM +0000, Chris Wilson wrote:
>> Quoting Chris Wilson (2019-11-01 10:51:06)
>>> The gem_exec_reloc basic subtests cover a couple dozen basic ABI
>>> sanitychecks, aiming to prove the ABI works. While relocations used to
>>> be essential, they are no longer the basis of current clients who all
>>> softpin. It is a stagnant portion of the ABI that does not contribute
>>> much to overall driver health (the complicated portions of relocs are
>>> covered in the smoketests like gem_exec_parallel and gem_exec_gttfill).
>>> However, even though each of the basic subtest is trivial and runs in
>>> very little time, since CI is running each individually the time between
>>> tests mounts up (especially on eMMC devices like fi-kbl-soraka).
>>>
>>> By moving these tests to the shards we should speed up BAT on the
>>> ratelimiting fi-kbl-soraka, while losing no coverage overall -- and
>>> hopefully without losing any of the predictive failure coverage in BAT.
>>> This stagnant bit of uAPI/uABI will remain checked by the irregular idle
>>> runs.
>>>
>>> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>>> Cc: Tomi Sarvela <tomi.p.sarvela at intel.com>
>>> Cc: Petri Latvala <petri.latvala at intel.com>
>>> Cc: Martin Peres <martin.peres at linux.intel.com>
>>
>> Before Joonas went fishing, he gave +1. So,
>> Acked-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>>
>> Tomi, Petri, Martin any objections?
>> -Chris
> 
> Acked-by: Petri Latvala <petri.latvala at intel.com>

Looks reasonable, and I like it.

Acked-by: Tomi Sarvela <tomi.p.sarvela at intel.com>

-- 
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


More information about the igt-dev mailing list