[igt-dev] [Intel-gfx] [PATCH i-g-t 3/7] lib/i915: Add query to detect if engine accepts only ro batches

[Chris Wilson]

Quoting Mika Kuoppala (2019-11-13 15:49:09)
> From: "Kuoppala, Mika" <mika.kuoppala at intel.com>
> 
> If cmd parser is mandatory, batch can't be modified post execbuf.
> Some tests rely on modifying batch post execbuf. Give those
> tests a method to query if those modifications ever reach
> the actual engine command stream.
> 
> v2: pull in the test changes, doh
> v3: class based query
> v4: rebase
> 
> Signed-off-by: Kuoppala, Mika <mika.kuoppala at intel.com>
> ---
>  lib/i915/gem_submission.c      | 62 ++++++++++++++++++++++++++++++++++
>  lib/i915/gem_submission.h      |  2 ++
>  tests/i915/gem_busy.c          |  7 +++-
>  tests/i915/gem_exec_async.c    |  3 ++
>  tests/i915/gem_exec_await.c    |  7 +++-
>  tests/i915/gem_exec_fence.c    |  8 +++++
>  tests/i915/gem_exec_latency.c  |  7 ++++
>  tests/i915/gem_exec_nop.c      |  4 ++-
>  tests/i915/gem_exec_schedule.c |  6 +++-
>  tests/i915/gem_exec_whisper.c  |  4 ++-
>  tests/prime_busy.c             |  3 ++
>  tests/prime_vgem.c             |  6 ++++
>  12 files changed, 114 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
> index 4f946493..9bdf28bc 100644
> --- a/lib/i915/gem_submission.c
> +++ b/lib/i915/gem_submission.c
> @@ -64,6 +64,22 @@ static bool has_semaphores(int fd, int dir)
>         return val;
>  }
>  
> +static int cmd_parser_version(int fd)

gem_cmdparser_version() ?

Drop the engine parameter as it turns out you didn't need it.
-Chris