[igt-dev] [CI PATCH i-g-t 1/1] i915/gem_exec_basic: Use dynamic subtests

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 18 10:33:20 UTC 2019


Quoting Petri Latvala (2019-11-18 10:17:31)
> Instead of generating a subtest for each engine in a static list,
> convert to dynamic subtests, with one dynamic subtest per actually
> present physical engine.
> 
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>
> ---
>  tests/i915/gem_exec_basic.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 1287860b..b2d6ddc2 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -159,13 +159,25 @@ igt_main
>         igt_subtest("gtt-all")
>                 gtt_all(fd);
>  
> -       __for_each_physical_engine(fd, e) {
> -               igt_subtest_f("basic-%s", e->name)
> -                       noop(fd, e->flags);
> -               igt_subtest_f("readonly-%s", e->name)
> -                       readonly(fd, e->flags);
> -               igt_subtest_f("gtt-%s", e->name)
> -                       gtt(fd, e->flags);
> +       igt_subtest_with_dynamic_subsubtests("basic") {

igt_subtest_with_dynamic("basic")

> +               __for_each_physical_engine(fd, e) {
> +                       igt_dynamic_subsubtest_f("%s", e->name)

igt_dynamic_f()

Simply regard igt_dynamic as being a particular case within the group?
-Chris


More information about the igt-dev mailing list