[igt-dev] [PATCH i-g-t v3 3/4] tests/i915/gem_mmap_offset: Add new API test for gem_mmap_offset
Chris Wilson
chris at chris-wilson.co.uk
Wed Nov 20 19:50:55 UTC 2019
Quoting Zbigniew Kempczyński (2019-11-20 18:57:38)
> From: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
>
> This test is a copy/paste of few gem_mmap subtests, due to good
> coverage in previous one. We also need to be sure that we cover
> all available memory regions.
>
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Vanshidhar Konda <vanshidhar.r.konda at intel.com>
> ---
> tests/Makefile.sources | 3 +
> tests/i915/gem_mmap_offset.c | 158 +++++++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 3 files changed, 162 insertions(+)
> create mode 100644 tests/i915/gem_mmap_offset.c
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 27801c89..9c6c3933 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -320,6 +320,9 @@ gem_mmap_SOURCES = i915/gem_mmap.c
> TESTS_progs += gem_mmap_gtt
> gem_mmap_gtt_SOURCES = i915/gem_mmap_gtt.c
>
> +TESTS_progs += gem_mmap_offset
> +gem_mmap_offset_SOURCES = i915/gem_mmap_offset.c
> +
> TESTS_progs += gem_mmap_offset_exhaustion
> gem_mmap_offset_exhaustion_SOURCES = i915/gem_mmap_offset_exhaustion.c
>
> diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> new file mode 100644
> index 00000000..5215d82e
> --- /dev/null
> +++ b/tests/i915/gem_mmap_offset.c
> @@ -0,0 +1,158 @@
> +/*
> + * Copyright © 2019 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +#include "igt.h"
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include "drm.h"
> +
> +IGT_TEST_DESCRIPTION("Basic MMAP_OFFSET IOCTL tests for mem regions\n");
> +
> +static int mmap_offset_ioctl(int fd, struct local_i915_gem_mmap_offset *arg)
> +{
> + int err = 0;
> +
> + if (igt_ioctl(fd, LOCAL_IOCTL_I915_GEM_MMAP_OFFSET, arg))
> + err = -errno;
> +
> + errno = 0;
> + return err;
> +}
> +
> +igt_main
> +{
> + uint8_t *addr;
> + uint32_t obj_size, batch_size;
> + uint32_t mem_type, mem_instance;
> + uint32_t region;
> + int fd;
> + const struct intel_memory_region *mr;
> + struct local_i915_query_memory_region_info *query_info;
> +
> + igt_fixture {
> + fd = drm_open_driver(DRIVER_INTEL);
> + gem_require_mmap_offset(fd);
> + igt_require(gem_mmap__has_wc(fd));
> +
> + query_info = gem_query_memory_regions(fd);
> + igt_assert(query_info);
This ioctl will be available before memory regions uAPI, and we will be
expecting coverage...
gem_mmap_offset_regions
or
gem_memory_regions_mmap
or just igt_subtest_group {}
And do we have a plan for switching to something like i915_gem_ instead?
> + }
> +
> + for (mr = intel_memory_regions; mr->region_name; mr++) {
See igt_subtest_with_dynamic
> + mem_type = mr->memory_type;
> + mem_instance = mr->memory_instance;
> + region = INTEL_MEMORY_REGION_ID(mem_type, mem_instance);
> + batch_size = gem_get_batch_size(fd, region);
> + obj_size = 4 * batch_size;
> +
> + igt_subtest_f("bad-object-%s", mr->region_name) {
> + uint32_t real_handle;
> + uint32_t handles[20];
> + int i = 0;
> +
> + gem_query_require_region(query_info, region);
> +
> + real_handle = gem_create_in_memory_regions(fd, obj_size,
> + region);
> +
> + handles[i++] = 0xdeadbeef;
> + for (int bit = 0; bit < 16; bit++)
> + handles[i++] = real_handle | (1 << (bit + 16));
> + handles[i] = real_handle + 1;
> +
> + for (; i >= 0; i--) {
> + struct local_i915_gem_mmap_offset arg = {
> + .handle = handles[i],
> + .flags = LOCAL_I915_MMAP_OFFSET_WC,
> + };
> +
> + igt_debug("Trying MMAP IOCTL with handle %x\n",
> + handles[i]);
> + igt_assert_eq(mmap_offset_ioctl(fd, &arg),
> + -ENOENT);
> + }
> +
> + gem_close(fd, real_handle);
> + }
> +
> + igt_subtest_f("basic-%s", mr->region_name) {
> + uint32_t handle;
> + uint64_t flags;
> + uint8_t *expected;
> + uint8_t *buf;
> +
> + gem_query_require_region(query_info, region);
> +
> + handle = gem_create_in_memory_regions(fd, obj_size,
> + region);
> + flags = LOCAL_I915_MMAP_OFFSET_WC;
> + addr = __gem_mmap_offset(fd, handle, 0, obj_size,
> + PROT_READ | PROT_WRITE,
> + flags);
> + igt_assert(addr);
> +
> + igt_debug("Testing contents of newly created object.\n");
> + expected = calloc(obj_size, sizeof(*expected));
> + igt_assert_eq(memcmp(addr, expected, obj_size), 0);
> + free(expected);
> +
> + igt_debug("Testing coherency of writes and mmap reads.\n");
> + buf = calloc(obj_size, sizeof(*buf));
> + memset(buf + 1024, 0x01, 1024);
> + gem_write(fd, handle, 0, buf, obj_size);
> + igt_assert_eq(memcmp(buf, addr, obj_size), 0);
> +
> + igt_debug("Testing that mapping stays after close\n");
> + gem_close(fd, handle);
> + igt_assert_eq(memcmp(buf, addr, obj_size), 0);
> + free(buf);
> +
> + igt_debug("Testing unmapping\n");
> + munmap(addr, obj_size);
> + }
> +
> + igt_subtest_f("short-mmap-%s", mr->region_name) {
> + uint32_t handle;
Not supported in vanilla ioctl, coming to an extension near you :)
-Chris
More information about the igt-dev
mailing list