[igt-dev] [PATCH i-g-t v3 2/4] lib/i915/intel_memory_region: Add lib to manage memory regions

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Wed Nov 20 19:58:41 UTC 2019


On Wed, Nov 20, 2019 at 07:43:08PM +0000, Chris Wilson wrote:
> Quoting Zbigniew Kempczyński (2019-11-20 18:57:37)
> > +/**
> > + *  gem_get_batch_size:
> > + *  @fd: open i915 drm file descriptor
> > + *  @region: region in which we want to create a batch
> > + *
> > + *  FIXME: Currently function assumes we have 64K on DEVICE and 4K
> > + *  on SYSTEM memory. I know Chris is going to kill me for that
> > + *  but I'll fix this when patch with memory region page size detection
> > + *  will be merged.
> 
> How am I supposed to rant now?
> -Chris

I've seen your comment on Łukasz patch, so I guessed you'll be 
angry I'm trying to put same/similar code. I'm sorry for that,
I'm going to fix that later when Janusz patch will land in IGT.
This shortcoming can be then easily fixed using his code then,
so please forgive me hard joke. But you started first on irc 
frightening me with leopard ;-)

Zbigniew 


More information about the igt-dev mailing list