[igt-dev] [PATCH i-g-t v3 1/4] lib/i915/gem_mman: add mmap_offset support

[Chris Wilson]

Quoting Zbigniew Kempczyński (2019-11-21 07:25:20)
> On Wed, Nov 20, 2019 at 07:41:45PM +0000, Chris Wilson wrote:
> > > +#define LOCAL_I915_PARAM_MMAP_OFFSET_VERSION 54
> > > +
> > > +static bool gem_has_mmap_offset(int fd)
> > > +{
> > > +       int has_mmap_offset = 0;
> > > +       struct drm_i915_getparam gp;
> > > +
> > > +       memset(&gp, 0, sizeof(gp));
> > > +       gp.param = LOCAL_I915_PARAM_MMAP_OFFSET_VERSION;
> > > +       gp.value = &has_mmap_offset;
> > > +       ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp);
> > 
> > * Blinks.
> > 
> > Oh no it isn't.
> > 
> > It's just I915_PARAM_MMAP_GTT_VERSION >= 4
> 
> I've double checked:
> 
> i915_getparam:
>         case I915_PARAM_MMAP_GTT_VERSION:
>                  -> i915_gem_mmap_gtt_version()
>                         -> return 3
> 
>         case I915_PARAM_MMAP_OFFSET_VERSION:
>                 -> return 1
> 
> Where's the magic 4 in GTT_VERSION? I don't see it.
> Is some non merged patch containing it?

You are looking at the unmerged garbage pile.
-Chris