[igt-dev] [PATCH i-g-t v3 4/4] tests/i915/gem_exec_basic: Iterate over all memory regions

[Chris Wilson]

Quoting Zbigniew Kempczyński (2019-11-21 08:40:11)
> On Wed, Nov 20, 2019 at 07:53:02PM +0000, Chris Wilson wrote:
> > Quoting Zbigniew Kempczyński (2019-11-20 18:57:39)
> > > From: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> > > 
> > > As a part of local memory effort we need to make sure, that basic
> > > scenarios are covered for every available memory region. This patch is
> > > an attempt for this problem. If it will be accepted it will be
> > > replicated on each test that can benefit from it.
> > 
> > gem_exec_basic just exercises the execbuf ioctl... which does not
> > mention memory region. You are thinking of gem_exec_nop and
> > gem_exec_store for this first level of basic testing.
> > -Chris
> 
> Drop it?

Yeah, I see gem_exec_basic as only doing the sanitychecks for the
execbuf2 ioctl itself, which basically only needs to answer the question
of whether the ioctl exists, and is usable by other tests. It such a
broad ioctl interfacing with all parts of the HW that we do need to
break it down into parts, and asking whether it is usable with all
memory regions accessible from the system, goes beyond the simple
question of whether the tests who do not care about that (and just use
the defaults handed to them) will work.
-Chris