[igt-dev] [PATCH i-g-t 1/3] i915/gem_eio: Retighten timeouts for forced reset

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Oct 7 16:57:14 UTC 2019


On 05/10/2019 11:55, Chris Wilson wrote:
> The forced-reset itself should be immediate; it's just the wait after
> the health check where we appear to have issues!
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   tests/i915/gem_eio.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index 007b9fb70..7c8ff10df 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -76,12 +76,15 @@ static void trigger_reset(int fd)
>   	igt_kmsg(KMSG_DEBUG "Forcing GPU reset\n");
>   	igt_force_gpu_reset(fd);
>   
> +	/* The forced reset should be immediate */
> +	igt_assert_lte(igt_seconds_elapsed(&ts), 2);
> +
>   	/* And just check the gpu is indeed running again */
>   	igt_kmsg(KMSG_DEBUG "Checking that the GPU recovered\n");
>   	gem_test_engine(fd, ALL_ENGINES);
>   	igt_drop_caches_set(fd, DROP_ACTIVE);
>   
> -	/* We expect forced reset and health check to be quick. */
> +	/* We expect health check to be quick. */
>   	igt_assert_lte(igt_seconds_elapsed(&ts), 10);
>   }
>   
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the igt-dev mailing list