[igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check

Katarzyna Dec katarzyna.dec at intel.com
Thu Oct 10 07:55:28 UTC 2019


On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:

Usual approach for patches it to explain WHY we do things. WHAT is
self-explainable by code.
Adding commit msg could make patch more noticable.

Moreover - I would talk to author of the code what he thinks of this change.

Kasia

> Signed-off-by: Caz Yokoyama <caz.yokoyama at intel.com>
> ---
>  tests/i915/gem_exec_balancer.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index b2074486..abf90df6 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -1267,8 +1267,6 @@ igt_main
>  {
>  	int i915 = -1;
>  
> -	igt_skip_on_simulation();
> -
>  	igt_fixture {
>  		i915 = drm_open_driver(DRIVER_INTEL);
>  		igt_require_gem(i915);
> -- 
> 2.21.0.5.gaeb582a983
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list