[igt-dev] [PATCH i-g-t 3/3] tests/kms_tiled_display: Get rid of DP stuff

Ville Syrjala ville.syrjala at linux.intel.com
Mon Oct 14 18:13:15 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

There is nothing DP specific about the tile property. So
remove any mention of DP (and port sync which is an i915
hardware feature). Let's just talk about genlocked CRTCs
and tiled connectors, which is pretty generic.

Cc: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep at intel.com>
Cc: Manasi Navare <manasi.d.navare at intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/Makefile.sources                              |  2 +-
 .../{kms_dp_tiled_display.c => kms_tiled_display.c} | 13 +++----------
 tests/meson.build                                   |  2 +-
 3 files changed, 5 insertions(+), 12 deletions(-)
 rename tests/{kms_dp_tiled_display.c => kms_tiled_display.c} (96%)

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 343be050068c..3667393ab830 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -41,7 +41,6 @@ TESTS_progs = \
 	kms_cursor_edge_walk \
 	kms_cursor_legacy \
 	kms_dp_dsc \
-	kms_dp_tiled_display \
 	kms_draw_crc \
 	kms_fbcon_fbt \
 	kms_fence_pin_leak \
@@ -77,6 +76,7 @@ TESTS_progs = \
 	kms_sequence \
 	kms_setmode \
 	kms_sysfs_edid_timing \
+	kms_tiled_display \
 	kms_tv_load_detect \
 	kms_universal_plane \
 	kms_vblank \
diff --git a/tests/kms_dp_tiled_display.c b/tests/kms_tiled_display.c
similarity index 96%
rename from tests/kms_dp_tiled_display.c
rename to tests/kms_tiled_display.c
index 175ff12f453b..cc65c07483c2 100644
--- a/tests/kms_dp_tiled_display.c
+++ b/tests/kms_tiled_display.c
@@ -25,7 +25,7 @@
  *      <madhumitha.tolakanahalli.pradeep at intel.com>
  *  Manasi Navare <manasi.d.navare at intel.com>
  *
- * Display Port Tiled Display Test
+ * Tiled display genlocked CRTC test
  * This test parses the tile information of the connectors that have TILE
  * property set, sets up the framebuffer with correct offsets corresponding to
  * the tile offsets and does an atomic modeset with two CRTCs for two
@@ -41,7 +41,7 @@
 #include "drm_mode.h"
 #include "drm_fourcc.h"
 
-IGT_TEST_DESCRIPTION("Test for Transcoder Port Sync for Display Port Tiled Displays");
+IGT_TEST_DESCRIPTION("Test for genlocked CRTCs with tiled displays");
 
 typedef struct {
 	igt_output_t *output;
@@ -113,8 +113,7 @@ static void get_number_of_h_tiles(data_t *data)
 						       res->connectors[i]);
 		igt_assert(connector);
 
-		if (connector->connection == DRM_MODE_CONNECTED &&
-		    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+		if (connector->connection == DRM_MODE_CONNECTED) {
 			get_connector_tile_props(data, connector, &tile);
 
 			data->num_h_tiles = tile.num_h_tile;
@@ -138,12 +137,6 @@ static void get_connectors(data_t *data)
 
 		igt_assert(conns[count].connector);
 
-		if (conns[count].connector->connector_type !=
-		    DRM_MODE_CONNECTOR_DisplayPort) {
-			drmModeFreeConnector(conns[count].connector);
-			continue;
-		}
-
 		get_connector_tile_props(data, conns[count].connector,
 					 &conns[count].tile);
 
diff --git a/tests/meson.build b/tests/meson.build
index 7e3f9e0a48e3..780a38ccf436 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -26,7 +26,6 @@ test_progs = [
 	'kms_cursor_edge_walk',
 	'kms_cursor_legacy',
 	'kms_dp_dsc',
-	'kms_dp_tiled_display',
 	'kms_draw_crc',
 	'kms_fbcon_fbt',
 	'kms_fence_pin_leak',
@@ -62,6 +61,7 @@ test_progs = [
 	'kms_sequence',
 	'kms_setmode',
 	'kms_sysfs_edid_timing',
+	'kms_tiled_display',
 	'kms_tv_load_detect',
 	'kms_universal_plane',
 	'kms_vblank',
-- 
2.21.0



More information about the igt-dev mailing list